xishuaidelin commented on code in PR #24703:
URL: https://github.com/apache/flink/pull/24703#discussion_r1581998200


##########
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/join/stream/StreamingMiniBatchJoinOperatorTest.java:
##########
@@ -1953,4 +1947,61 @@ public RowType getOutputType() {
                     return FlinkJoinType.FULL;
                 }
             };
+
+    private final Function<String, InternalTypeInfo<RowData>> 
leftTypeInfoExtractor =
+            (testDisplayName) -> {
+                if (testDisplayName.contains("HashCollision")) {

Review Comment:
   Apologies for the delay in responding due to other work. Nit: could you make 
this statement be consistent with the following conditional statement?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to