gaborgsomogyi commented on code in PR #819:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/819#discussion_r1584790463
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/metrics/FlinkDeploymentMetrics.java:
##########
@@ -165,13 +194,21 @@ private void initNamespaceStatusCounts(String ns) {
private void initFlinkVersions(String ns, String flinkVersion) {
parentMetricGroup
.createResourceNamespaceGroup(configuration,
FlinkDeployment.class, ns)
- .addGroup(FLINK_VERSION_GROUP_NAME)
- .addGroup(flinkVersion)
+ .addGroup(FLINK_VERSION_GROUP_NAME, flinkVersion)
Review Comment:
This is not related, just merging the 2 statements to one, right?
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/metrics/FlinkDeploymentMetrics.java:
##########
@@ -94,6 +101,22 @@ public void onUpdate(FlinkDeployment flinkApp) {
})
.add(deploymentName);
+ // Minor version computed from the above
+ var subVersions = flinkVersion.split("\\.");
+ String minorVersion = MALFORMED_MINOR_VERSION;
Review Comment:
Not sure why not use `UNKNOWN` just like the other case but I'm fine with
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
