SinBex commented on code in PR #24736: URL: https://github.com/apache/flink/pull/24736#discussion_r1589991535
########## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchSchedulerTest.java: ########## Review Comment: We might need to verify the following case: when source vertex does not have `maxParallelism` set and the `defaultSourceParallelism` is greater than the `globalMaxParallelism`. ########## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismAndInputInfosDecider.java: ########## Review Comment: I feel that simply making changes here might not be adequate. We need to also consider the logic of the method `AdaptiveBatchScheduler#computeVertexParallelismStoreForDynamicGraph`. Imagine, when the source vertex uses globalMaxParallelism as its maxParallelism, if the inferred source parallelism is greater than the maxParallelism, then the method `DefaultVertexParallelismInfo#setParallelism` will throw an IllegalArgumentException. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
