Jiabao-Sun commented on code in PR #24603:
URL: https://github.com/apache/flink/pull/24603#discussion_r1552047820
##########
flink-core/src/test/java/org/apache/flink/api/java/typeutils/runtime/SubclassFromInterfaceSerializerTest.java:
##########
@@ -103,10 +103,7 @@ public boolean equals(Object other) {
if (dumm1 != otherTUC.dumm1) {
return false;
}
- if (!dumm2.equals(otherTUC.dumm2)) {
- return false;
- }
- return true;
+ return dumm2.equals(otherTUC.dumm2);
Review Comment:
We don't need these changes in this PR.
##########
flink-core/src/test/java/org/apache/flink/api/java/typeutils/runtime/PojoSerializerTest.java:
##########
@@ -173,11 +174,8 @@ public boolean equals(Object other) {
return false;
}
- if ((nestedClass == null && otherTUC.nestedClass != null)
- || (nestedClass != null &&
!nestedClass.equals(otherTUC.nestedClass))) {
- return false;
- }
- return true;
+ return (nestedClass != null || otherTUC.nestedClass == null)
+ && (nestedClass == null ||
nestedClass.equals(otherTUC.nestedClass));
Review Comment:
IMO, these changes are not necessary and unrelated to the JUnit migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
