lsyldliu commented on code in PR #24750:
URL: https://github.com/apache/flink/pull/24750#discussion_r1591784050
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java:
##########
@@ -143,11 +145,14 @@ public class OperationExecutor {
private final ClusterClientServiceLoader clusterClientServiceLoader;
+ private final MaterializedTableManager materializedTableManager;
+
@VisibleForTesting
public OperationExecutor(SessionContext context, Configuration
executionConfig) {
this.sessionContext = context;
this.executionConfig = executionConfig;
this.clusterClientServiceLoader = new
DefaultClusterClientServiceLoader();
+ this.materializedTableManager = new MaterializedTableManager(this);
Review Comment:
What do you see as the problem with circular references? I was mainly
thinking about getting a global object because we needed to pass in conf
information for the workflow scheduler for subsequent full refresh mode. Of
course, this way also makes sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
