xintongsong commented on code in PR #24753:
URL: https://github.com/apache/flink/pull/24753#discussion_r1592308269
##########
flink-filesystems/flink-gs-fs-hadoop/src/main/java/org/apache/flink/fs/gs/GSFileSystemOptions.java:
##########
@@ -80,6 +84,74 @@ public class GSFileSystemOptions {
.withDescription(
"This option sets the timeout in milliseconds to
read data from an established connection.");
+ /**
+ * Flink config option to set the http read timeout. It will be used by
cloud-storage library.
+ */
+ public static final ConfigOption<Integer> GCS_RETRY_MAX_ATTEMPT =
+ ConfigOptions.key("gs.retry.max-attempt")
+ .intType()
+ .defaultValue(6)
Review Comment:
I'm not sure about setting default values for these options. The default
values are ignored anyway because these options are only used in
`getOptional()`, which returns `empty()` if the option is not explicitly
configured by user. We can mention in the description that if not configured,
the GCS default values will be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
