1996fanrui commented on code in PR #24717:
URL: https://github.com/apache/flink/pull/24717#discussion_r1593316335
##########
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/NoFetchingInput.java:
##########
@@ -114,18 +117,26 @@ public void readBytes(byte[] bytes, int offset, int
count) throws KryoException
throw new IllegalArgumentException("bytes cannot be null.");
}
+ if (count == 0) {
+ return;
+ }
+
Review Comment:
This `if (count == 0) {` is alternative change for FLINK-34954, I ran the
demo that provided in FLINK-34954, it works well. So I think the change is fine.
Also, I ran the benchmark, the performance of serializerKryo and
serializerKryoWithoutRegistration are recovered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
