Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

Tue, 07 May 2024 21:40:37 -0700 


RocMarshal commented on code in PR #117:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/117#discussion_r1593374629


##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java:
##########
@@ -144,7 +146,8 @@ void testJdbcReadProperties() {
                         readOptions,
                         LookupOptions.MAX_RETRIES.defaultValue(),
                         null,
-                        SCHEMA.toPhysicalRowDataType());
+                        SCHEMA.toPhysicalRowDataType(),
+                        FactoryMocks.IDENTIFIER.asSummaryString());

Review Comment:
   
![image](https://github.com/apache/flink-connector-jdbc/assets/64569824/cf2db1b0-a933-40cd-8ea6-b44614c13713)
   
![image](https://github.com/apache/flink-connector-jdbc/assets/64569824/4a88a206-1390-4f61-aaef-d2e0208c9e51)
   
   
   I added the corresponding cases for testing.
   As shown in the screenshot pics, The name is overwrite by the translation 
mechanism.
   Maybe we should drop the `tableIdentifier` attribute at present ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to