1996fanrui commented on code in PR #24761:
URL: https://github.com/apache/flink/pull/24761#discussion_r1593436266
##########
flink-tests-java17/src/test/java/org/apache/flink/api/java/typeutils/runtime/PojoRecordSerializerUpgradeTestSpecifications.java:
##########
@@ -81,18 +80,19 @@ public TypeSerializer<PojoAfterUpgrade>
createUpgradedSerializer() {
TypeSerializer<PojoAfterUpgrade> serializer =
TypeExtractor.createTypeInfo(PojoAfterUpgrade.class)
.createSerializer(new SerializerConfigImpl());
- assertSame(PojoSerializer.class, serializer.getClass());
+ assertThat(serializer.getClass()).isSameAs(PojoSerializer.class);
return serializer;
}
@Override
- public Matcher<PojoAfterUpgrade> testDataMatcher() {
- return is(new PojoAfterUpgrade(911108, "Gordon"));
+ public Condition<PojoAfterUpgrade> testDataCondition() {
+ return new Condition<>(
+ new PojoAfterUpgrade(911108, "Gordon")::equals, "value is
(911108, Gordon");
Review Comment:
thanks @Zakelly for the quick review!
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
