pvary commented on code in PR #3233:
URL: https://github.com/apache/flink-cdc/pull/3233#discussion_r1593951427
##########
flink-cdc-composer/src/main/java/org/apache/flink/cdc/composer/flink/translator/DataSinkTranslator.java:
##########
@@ -71,7 +72,9 @@ public void translate(
}
}
- private void sinkTo(
+ /** Only visible for test */
+ @VisibleForTesting
+ protected void sinkTo(
Review Comment:
nit: The comment says the same, as the annotation, so it is not needed.
We can leave this as package private (slightly lower privileges than
`protected`.
```
@VisibleForTesting
void sinkTo(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
