Zakelly commented on PR #24653:
URL: https://github.com/apache/flink/pull/24653#issuecomment-2102053717

   > When passing `CheckpointStorageWorkerView` directly to 
`ChannelStateWriteRequestDispatcher`, `UnalignedCheckpointRescaleITCase` might 
throw exceptions when the task exits.
   > 
   > This is mainly because the task will close the stream held by the current 
thread when it exits, see 
`FileSystemSafetyNet#closeSafetyNetAndGuardedResourcesForThread`(Thanks for 
@1996fanrui's help).
   > 
   > Therefore, I let 
`ChannelStateWriteRequestDispatcher#CheckpointStorageWorkerView` be lazily 
initialized. and changed the `filesystem` in `FsMergingCheckpointStorageAccess` 
to unwrapped `filesystem`, to prevent different threads from interfering with 
each other when exiting.
   
   Will the `PhysicalFilePool` close while some streams are still being 
written? There might be leaks of opened streams?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to