snuyanzin commented on code in PR #24659:
URL: https://github.com/apache/flink/pull/24659#discussion_r1596379442
##########
flink-formats/flink-orc/src/test/java/org/apache/flink/orc/OrcFileSystemFilterTest.java:
##########
@@ -86,4 +83,49 @@ public void testApplyPredicate() {
OrcFilters.Predicate predicate8 = new OrcFilters.And(predicate4,
predicate6);
assertThat(predicate7).hasToString(predicate8.toString());
}
+
+ @Test
+ @SuppressWarnings("unchecked")
+ public void testApplyPredicateReverse() {
Review Comment:
```suggestion
void testApplyPredicateReverse() {
```
JUnit5 doesn't need public modifiers, so it's better harden them
could you please also do same for the test method above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
