nicusX commented on PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#issuecomment-2106039721
I addressed all comments, except those I explained why I didn't. Also, now upgraded to Flink 1.18 and newer AsyncSinkBase API. I cannot split AMP signer and connector in separate PRs at this point, because of the interdependency with the sample application. Also, I strongly recommend to keep the sample application in the repository, because it serves both as documentation for the user and a way to test the connector (and optionally the signer) in an actual environment. The sample application is not supposed to be released as artifact, but just to stay in the repo as source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
