nicusX commented on PR #122: URL: https://github.com/apache/flink-connector-aws/pull/122#issuecomment-2106854494
@z3d1k I addressed most of the comments. But I am not sure how to implement the IT, in particular for a *format* using an external registry. Any reference or example I can follow? Most of formats lack of IT. And this one requires an external system The only similar format, [flink-avro-confluent-registry](https://github.com/apache/flink/tree/master/flink-formats/flink-avro-confluent-registry/src/test/java/org/apache/flink/formats/avro/registry/confluent), doesn't have any IT. The [GRS Serialization/DeserializationSchema IT](https://github.com/nicusX/flink-connector-aws/blob/27db878e7da1d56d395ce80984912b16e5b916d4/flink-connector-aws-e2e-tests/flink-formats-avro-glue-schema-registry-e2e-tests/src/test/java/org/apache/flink/glue/schema/registry/test/GlueSchemaRegistryAvroKinesisITCase.java#L189) relies on a [AWS account](https://github.com/nicusX/flink-connector-aws/blob/27db878e7da1d56d395ce80984912b16e5b916d4/flink-connector-aws-e2e-tests/flink-formats-avro-glue-schema-registry-e2e-tests/src/test/java/org/apache/flink/glue/schema/registry/test/GlueSchemaRegistryAvroKinesisITCase.java#L69C61-L69C91) that I assume is available during the CI/CD build. Any reference on how to leverage this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
