MartijnVisser commented on code in PR #102:
URL:
https://github.com/apache/flink-connector-kafka/pull/102#discussion_r1599848408
##########
.github/workflows/push_pr.yml:
##########
@@ -28,21 +28,16 @@ jobs:
compile_and_test:
strategy:
matrix:
- flink: [ 1.17.2 ]
- jdk: [ '8, 11' ]
- include:
- - flink: 1.18.1
- jdk: '8, 11, 17'
- - flink: 1.19.0
- jdk: '8, 11, 17, 21'
+ flink: [ 1.19.0, 1.20-SNAPSHOT ]
+ jdk: [ '8, 11, 17, 21' ]
Review Comment:
Flink 1.19 doesn't support Java 21, so you'll probably have to make the
correct changes here.
##########
flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/TypeSerializerUpgradeTestBase.java:
##########
@@ -43,28 +40,19 @@
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.Paths;
+import java.util.ArrayList;
import java.util.Collection;
-import java.util.Set;
+import java.util.List;
import static org.apache.flink.util.Preconditions.checkNotNull;
import static org.apache.flink.util.Preconditions.checkState;
-import static org.assertj.core.api.AssertionsForInterfaceTypes.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assumptions.assumeThat;
-import static org.hamcrest.CoreMatchers.not;
-/**
- * A test base for testing {@link TypeSerializer} upgrades.
- *
- * <p>You can run {@link #generateTestSetupFiles(TestSpecification)} on a
Flink branch to
- * (re-)generate the test data files.
- */
+/** A test base for testing {@link TypeSerializer} upgrades. */
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
-public abstract class TypeSerializerUpgradeTestBase<PreviousElementT,
UpgradedElementT> {
-
- public static final FlinkVersion CURRENT_VERSION = FlinkVersion.v1_17;
-
- public static final Set<FlinkVersion> MIGRATION_VERSIONS =
- FlinkVersion.rangeOf(FlinkVersion.v1_11, CURRENT_VERSION);
+public abstract class TypeSerializerUpgradeTestBase<PreviousElementT,
UpgradedElementT>
Review Comment:
Can't we now get rid of this one completely? I thought we copied this one
over as part of
https://issues.apache.org/jira/browse/FLINK-32455?focusedCommentId=17739785&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17739785
as a temporary solution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
