snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/27#discussion_r1601875238
########## flink-connector-gcp-pubsub/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/PubSubSinkV2BuilderTest.java: ########## @@ -0,0 +1,133 @@ +package org.apache.flink.connector.gcp.pubsub.sink; + +import org.apache.flink.api.common.serialization.SerializationSchema; +import org.apache.flink.api.common.serialization.SimpleStringSchema; +import org.apache.flink.connector.gcp.pubsub.sink.config.GcpPublisherConfig; + +import com.google.api.gax.core.NoCredentialsProvider; +import org.assertj.core.api.Assertions; +import org.junit.jupiter.api.Test; + +import static org.apache.flink.connector.gcp.pubsub.common.PubSubConstants.DEFAULT_FAIL_ON_ERROR; +import static org.apache.flink.connector.gcp.pubsub.common.PubSubConstants.DEFAULT_MAXIMUM_INFLIGHT_REQUESTS; + +/** Tests for {@link PubSubSinkV2Builder}. */ +public class PubSubSinkV2BuilderTest { Review Comment: ```suggestion class PubSubSinkV2BuilderTest { ``` junit5 doesn't need `public` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org