pnowojski commented on code in PR #24784:
URL: https://github.com/apache/flink/pull/24784#discussion_r1602832692
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java:
##########
@@ -421,7 +423,27 @@ public void
reDistributeInputChannelStates(TaskStateAssignment stateAssignment)
stateAssignment.oldState.get(stateAssignment.inputOperatorID);
final List<List<InputChannelStateHandle>> inputOperatorState =
splitBySubtasks(inputState,
OperatorSubtaskState::getInputChannelState);
- if (inputState.getParallelism() ==
executionJobVertex.getParallelism()) {
+
+ boolean noNeedRescale =
+
stateAssignment.executionJobVertex.getJobVertex().getInputs().stream()
+ .map(JobEdge::getDownstreamSubtaskStateMapper)
+ .anyMatch(m ->
!m.equals(SubtaskStateMapper.FULL))
+ &&
stateAssignment.executionJobVertex.getInputs().stream()
+ .map(IntermediateResult::getProducer)
+ .map(vertexAssignments::get)
+ .anyMatch(
+ taskStateAssignment -> {
+ final int oldParallelism =
+ stateAssignment
+ .oldState
+
.get(stateAssignment.inputOperatorID)
+ .getParallelism();
+ return oldParallelism
+ ==
taskStateAssignment.executionJobVertex
+ .getParallelism();
+ });
Review Comment:
Thanks for the explanation.
> But I made little mistake in condition. I will fix it
Does this bug have a test coverage? I mean, either was there some test
failing or have you added a new test to cover for a future regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
