Github user thvasilo commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2761#discussion_r89645498
  
    --- Diff: 
flink-examples/flink-examples-streaming/src/main/scala/org/apache/flink/streaming/scala/examples/kafka/ReadFromKafka.scala
 ---
    @@ -0,0 +1,72 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.scala.examples.kafka
    +
    +import org.apache.flink.api.common.restartstrategy.RestartStrategies
    +import org.apache.flink.api.java.utils.ParameterTool
    +import org.apache.flink.streaming.api.scala._
    +import org.apache.flink.streaming.connectors.kafka.FlinkKafkaConsumer08
    +import org.apache.flink.streaming.util.serialization.SimpleStringSchema
    +
    +/**
    +  * Read Strings from Kafka and print them to standard out.
    +  * Note: On a cluster, DataStream.print() will print to the TaskManager's 
.out file!
    +  *
    +  * Please pass the following arguments to run the example:
    +  * --topic test
    +  * --bootstrap.servers localhost:9092
    +  * --zookeeper.connect localhost:2181
    +  * --group.id myconsumer
    +  *
    +  */
    +object ReadFromKafka {
    +
    +  def main(args: Array[String]): Unit = {
    +
    +    // parse input arguments
    +    val params = ParameterTool.fromArgs(args)
    +
    +    if (params.getNumberOfParameters < 4) {
    +      println("Missing parameters!\nUsage: Kafka --topic <topic> " +
    +        "--bootstrap.servers <kafka brokers> --zookeeper.connect <zk 
quorum> --group.id <some id>")
    +      return
    +    }
    +
    +    val env = StreamExecutionEnvironment.getExecutionEnvironment
    +    env.getConfig.disableSysoutLogging
    +    
env.getConfig.setRestartStrategy(RestartStrategies.fixedDelayRestart(4, 10000))
    +    // create a checkpoint every 5 seconds
    +    env.enableCheckpointing(5000)
    +    // make parameters available in the web interface
    +    env.getConfig.setGlobalJobParameters(params)
    +
    +    // create a Kafka streaming source consumer for Kafka 0.8.x
    +    val kafkaConsumer = new FlinkKafkaConsumer08(
    --- End diff --
    
    I would suggest to keep it as is for now unless a project committer 
suggests otherwise. 
    
    The linked issue would indicate that the intention is to have different 
versions, but I guess that would affect the release as well, since different 
jar files would need to be generated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to