vahmed-hamdy commented on code in PR #29:
URL:
https://github.com/apache/flink-connector-rabbitmq/pull/29#discussion_r1604717135
##########
flink-connector-rabbitmq/src/main/java/org/apache/flink/connector/rabbitmq/common/RabbitMQConnectionConfig.java:
##########
@@ -0,0 +1,465 @@
+package org.apache.flink.connector.rabbitmq.common;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.streaming.connectors.rabbitmq.RMQSource;
+import
org.apache.flink.streaming.connectors.rabbitmq.common.RMQConnectionConfig;
+import org.apache.flink.util.Preconditions;
+
+import java.io.Serializable;
+import java.util.Optional;
+import java.util.concurrent.TimeUnit;
+
+/** Configuration class for RabbitMQ connections. */
+@PublicEvolving
+public class RabbitMQConnectionConfig implements Serializable {
+ private static final long DEFAULT_DELIVERY_TIMEOUT = 30000;
+
+ private String host;
+ private Integer port;
+ private String virtualHost;
+ private String username;
+ private String password;
+ private String uri;
+
+ private Integer networkRecoveryInterval;
+ private Boolean automaticRecovery;
+ private Boolean topologyRecovery;
+
+ private Integer connectionTimeout;
+ private Integer requestedChannelMax;
+ private Integer requestedFrameMax;
+ private Integer requestedHeartbeat;
Review Comment:
Where are the default mentioned, the behaviour of the deprecated sink is to
set them if not null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
