luoyuxia commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-hive/pull/18#discussion_r1594867337
##########
flink-connector-hive/src/main/java/org/apache/flink/table/planner/delegation/hive/parse/HiveASTParser.g:
##########
@@ -721,6 +722,12 @@ import
org.apache.flink.table.planner.delegation.hive.copy.HiveASTParseError;
public void setHiveConf(Configuration hiveConf) {
this.hiveConf = hiveConf;
}
+ protected boolean useSQL11ReservedKeywordsForIdentifier() {
+ if(hiveConf==null){
+ return false;
+ }
+ return
!hiveConf.getBoolean(SUPPORT_SQL11_RESERVED_KEYWORDS_AS_IDENTIFIERS_CONFIG_NAME,
true);
Review Comment:
nit:
```suggestion
return
hiveConf.getBoolean(SUPPORT_SQL11_RESERVED_KEYWORDS_AS_IDENTIFIERS_CONFIG_NAME,
false);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
