[
https://issues.apache.org/jira/browse/FLINK-35408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17848161#comment-17848161
]
david radley commented on FLINK-35408:
--------------------------------------
some feedback:
* I wonder why you need a 30 minute tolerance for mySQL time zone setting for
CDC?
* you have no unit tests in your pr.
* I notice [Australia|https://en.wikipedia.org/wiki/Australia]: [Lord Howe
Island|https://en.wikipedia.org/wiki/Lord_Howe_Island] has 30 minute DSL -
will this work?
* as this is an improvement - a Flip is the usual process - is there a reason
you are not raising a Flip for this.
> Add 30 min tolerance value when validating the time-zone setting
> ----------------------------------------------------------------
>
> Key: FLINK-35408
> URL: https://issues.apache.org/jira/browse/FLINK-35408
> Project: Flink
> Issue Type: Improvement
> Components: Flink CDC
> Reporter: Xiao Huang
> Priority: Minor
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
