Mrart commented on code in PR #3336:
URL: https://github.com/apache/flink-cdc/pull/3336#discussion_r1608399656
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/main/java/org/apache/flink/cdc/connectors/tidb/TDBSourceOptions.java:
##########
@@ -82,10 +90,13 @@ private TDBSourceOptions() {}
.withDescription("TiKV GRPC batch scan concurrency");
public static TiConfiguration getTiConfiguration(
- final String pdAddrsStr, final Map<String, String> options) {
+ final String pdAddrsStr, final String hostMapping, final
Map<String, String> options) {
Review Comment:
hostMapping is an optional variable and returns tiConfiguration.Adding a new
method would increase the complexity of the code. Change to Optional.of(new
UriHostMapping(hostMapping)).ifPresent(tiConf::setHostMapping);
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-tidb-cdc/src/main/java/org/apache/flink/cdc/connectors/tidb/TDBSourceOptions.java:
##########
@@ -82,10 +90,13 @@ private TDBSourceOptions() {}
.withDescription("TiKV GRPC batch scan concurrency");
public static TiConfiguration getTiConfiguration(
- final String pdAddrsStr, final Map<String, String> options) {
+ final String pdAddrsStr, final String hostMapping, final
Map<String, String> options) {
final Configuration configuration = Configuration.fromMap(options);
final TiConfiguration tiConf =
TiConfiguration.createDefault(pdAddrsStr);
+ if (StringUtils.isNotBlank(hostMapping)) {
Review Comment:
Optional.of(new
UriHostMapping(hostMapping)).ifPresent(tiConf::setHostMapping);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
