davidradl commented on code in PR #24754:
URL: https://github.com/apache/flink/pull/24754#discussion_r1609838609
##########
flink-clients/src/main/java/org/apache/flink/client/deployment/application/executors/EmbeddedExecutor.java:
##########
@@ -153,7 +173,14 @@ private CompletableFuture<JobClient>
submitAndGetJobClientFuture(
return jobId;
}))
.thenApplyAsync(
- jobID -> jobClientCreator.getJobClient(actualJobId,
userCodeClassloader));
+ jobID -> jobClientCreator.getJobClient(actualJobId,
userCodeClassloader))
+ .whenCompleteAsync(
+ (jobClient, throwable) -> {
+ if (throwable == null) {
Review Comment:
Should we do something if there is a throwable . Maybe notify to the job
status changed listeners that there was an error and log the error. If there is
a good reason to swallow the throwable here, then a comment explaining would be
good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
