JingGe commented on code in PR #24795:
URL: https://github.com/apache/flink/pull/24795#discussion_r1610586619
##########
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java:
##########
@@ -381,9 +381,16 @@ private MapWriter(LogicalType keyType, LogicalType
valueType, GroupType groupTyp
@Override
public void write(RowData row, int ordinal) {
- recordConsumer.startGroup();
+ writeMapData(row.getMap(ordinal));
+ }
- MapData mapData = row.getMap(ordinal);
+ @Override
+ public void write(ArrayData arrayData, int ordinal) {
Review Comment:
NIT: Not sure why those write(ArrayData arrayData, int ordinal) methods
didn't get implemented. It should be trivial to do it while building those
Writers. Do you have any hints about the background info?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
