Mrart commented on code in PR #108:
URL:
https://github.com/apache/flink-connector-jdbc/pull/108#discussion_r1611757713
##########
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/AbstractPostgresCompatibleDialect.java:
##########
@@ -56,6 +56,7 @@ public Optional<String> getUpsertStatement(
.collect(Collectors.joining(", "));
String updateClause =
Arrays.stream(fieldNames)
+ .filter(f ->
!Arrays.asList(uniqueKeyFields).contains(f))
Review Comment:
Thanks @1996fanrui , I think that was a little bit inaccurate, update clause
must exclude unique index . If not will case execptions like 'modification of
distribution columns in OnConflictUpdate is not supported Call getNextException
to see other errors in the batch'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
