JunRuiLee commented on code in PR #24771:
URL: https://github.com/apache/flink/pull/24771#discussion_r1612900377


##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java:
##########
@@ -1012,12 +1013,12 @@ public 
CompletableFuture<Collection<PartitionWithMetrics>> getPartitionWithMetri
                                             timeout.toMillis(),
                                             expectedPartitions);
 
-                                    return 
fetchedPartitionsWithMetrics.values();
+                                    return new 
ArrayList<>(fetchedPartitionsWithMetrics.values());

Review Comment:
   Because the values() method of HashMap returns a collection that is not 
serializable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to