[
https://issues.apache.org/jira/browse/FLINK-35435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849270#comment-17849270
]
Ahmed Hamdy commented on FLINK-35435:
-------------------------------------
h1. Non-Functional Backward compatibility
To assure that we haven't imposed any regressions to existing implementers we
tested {{ KinesisStreamsSink }} with default request timeout vs no timeout on 2
levels
h2. Sanity testing
We have run the [example
job|https://github.com/apache/flink-connector-aws/blob/main/flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/sink/examples/SinkIntoKinesis.java]
with checkpoint interval of 10 seconds, we set the request timeout for 3
minutes and verified no requests were retried due to timeout during a period of
30 minutes of job execution.
h2. Performance Benchmark
I have benchmarked the kinesis sink with the default timeout (10 minutes) with
batch size = 20, and default values of inflight requests.
The result show no difference (except for a small network blip)
h3. Sink With Timeout
!Screenshot 2024-05-24 at 11.06.30.png!
h3. Sink With No Timeout
!Screenshot 2024-05-24 at 12.06.20.png!
> [FLIP-451] Introduce timeout configuration to AsyncSink
> -------------------------------------------------------
>
> Key: FLINK-35435
> URL: https://issues.apache.org/jira/browse/FLINK-35435
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Common
> Reporter: Ahmed Hamdy
> Priority: Major
> Fix For: 1.20.0
>
> Attachments: Screenshot 2024-05-24 at 11.06.30.png, Screenshot
> 2024-05-24 at 12.06.20.png
>
>
> Implementation Ticket for:
> https://cwiki.apache.org/confluence/display/FLINK/FLIP-451%3A+Introduce+timeout+configuration+to+AsyncSink+API
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
