liuml07 commented on code in PR #104:
URL:
https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1613711076
##########
flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java:
##########
@@ -0,0 +1,69 @@
+package org.apache.flink.connector.elasticsearch.sink;
+
+import org.apache.http.util.EntityUtils;
+import org.elasticsearch.client.Request;
+import org.elasticsearch.client.Response;
+import org.elasticsearch.client.RestClient;
+import org.testcontainers.utility.DockerImageName;
+
+import java.io.IOException;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+/** Utility class for Elasticsearch8 tests. */
+public class Elasticsearch8TestUtils {
Review Comment:
Good question, it's not required. `ElasticsearchSinkBaseITCase` creates a
static ES container while the new test `Elasticsearch8AsyncSinkSecureITCase`
needs to create the secure ES container. The new one does not really inherit
this base class, but simply refer to those static fields. I think it's a bit
clearer to extract those common fields and methods so secure vs. non-secure
tests are completely independent.
I don't have strong preference on this and can move it back to the
`ElasticsearchSinkBaseITCase` class if we feel it's better to keep them in the
base class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
