liuml07 commented on code in PR #104: URL: https://github.com/apache/flink-connector-elasticsearch/pull/104#discussion_r1614242366
########## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch8TestUtils.java: ########## @@ -0,0 +1,69 @@ +package org.apache.flink.connector.elasticsearch.sink; + +import org.apache.http.util.EntityUtils; +import org.elasticsearch.client.Request; +import org.elasticsearch.client.Response; +import org.elasticsearch.client.RestClient; +import org.testcontainers.utility.DockerImageName; + +import java.io.IOException; + +import static org.assertj.core.api.Assertions.assertThat; + +/** Utility class for Elasticsearch8 tests. */ +public class Elasticsearch8TestUtils { Review Comment: Sounds good, @reta ! Thanks for the review and helpful comments. Let's see if @snuyanzin has bandwidth to take a look while I'm trying to refactor the tests separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org