Zakelly commented on code in PR #24846:
URL: https://github.com/apache/flink/pull/24846#discussion_r1615989878
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java:
##########
@@ -131,19 +131,22 @@ public abstract class FileMergingSnapshotManagerBase
implements FileMergingSnaps
/**
* The {@link DirectoryStreamStateHandle} for shared state directories,
one for each subtask.
*/
+ @GuardedBy("lock")
Review Comment:
Well, the `fileSystemInitiated`, `checkpointDir`, `sharedStateDir ` and
`taskOwnedStateDir` would also be `@GuardedBy("lock")`. I'd suggest removing
this since this is controlling one-time initialization, not a typical
concurrent modification scenario.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
