RocMarshal commented on code in PR #830:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1620723423
##########
docs/content/docs/custom-resource/pod-template.md:
##########
@@ -113,10 +112,10 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}]
merged: [{name: a, p1: v1, p2: v2}, {name: c, p1: v1, p2: v2}]
```
-The operator supports an alternative array merging mechanism that can be
enabled by the `kubernetes.operator.pod-template.merge-arrays-by-name` flag.
-When true, instead of the default positional merging, object array elements
that have a `name` property defined will be merged by their name and the
resulting array will be a union of the two input arrays.
+Operator支持另一种数组合并机制，可以通过`kubernetes.operator.pod-template.merge-arrays-by-name`标志启用。
Review Comment:
```suggestion
Operator 支持另一种数组合并机制，可以通过
`kubernetes.operator.pod-template.merge-arrays-by-name` 标志启用。
```
##########
docs/content/docs/custom-resource/pod-template.md:
##########
@@ -93,16 +90,18 @@ spec:
```
{{< hint info >}}
-When using the operator with Flink native Kubernetes integration, please refer
to [pod template field precedence](
-https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/resource-providers/native_kubernetes/#fields-overwritten-by-flink).
+当使用具有 Flink 原生 Kubernetes 集成的 operator 时，请参考 [pod template 字段优先级](
+https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/resource-providers/native_kubernetes/#fields-overwritten-by-flink)。
{{< /hint >}}
+
## Array Merging Behaviour
-When layering pod templates (defining both a top level and jobmanager specific
podtemplate for example) the corresponding yamls are merged together.
+<a name="array-meging-behaviour"></a>
+
+当分层 pod templates（例如同时定义顶级和任务管理器特定的 pod 模板）时，相应的 yaml 会合并在一起。
-The default behaviour of the pod template mechanism is to merge array arrays
by merging the objects in the respective array positions.
-This requires that containers in the podTemplates are defined in the same
order otherwise the results may be undefined.
+Pod 模板机制的默认行为是通过合并相应数组位置的对象合并数组类型的数组。
Review Comment:
`数组类型的数组` -> ` json 类型的数组`
Sorry for the previous comment on ignoring the demo lines.
Maybe the new comments is appropriate.
##########
docs/content/docs/custom-resource/pod-template.md:
##########
@@ -113,10 +112,10 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}]
merged: [{name: a, p1: v1, p2: v2}, {name: c, p1: v1, p2: v2}]
```
-The operator supports an alternative array merging mechanism that can be
enabled by the `kubernetes.operator.pod-template.merge-arrays-by-name` flag.
-When true, instead of the default positional merging, object array elements
that have a `name` property defined will be merged by their name and the
resulting array will be a union of the two input arrays.
+Operator支持另一种数组合并机制，可以通过`kubernetes.operator.pod-template.merge-arrays-by-name`标志启用。
+当为true时，将按名称合并具有`name`属性定义的对象数组元素，并且生成的数组将是两个输入数组的并集。
Review Comment:
```suggestion
当为 true 时，将按名称合并具有 `name` 属性定义的对象数组元素，并且生成的数组将是两个输入数组的并集。
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
