jectpro7 commented on code in PR #24836:
URL: https://github.com/apache/flink/pull/24836#discussion_r1622608260
##########
flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkConnection.java:
##########
@@ -83,6 +83,13 @@ public Statement createStatement() throws SQLException {
return statement;
}
+ // TODO We currently do not support this, but we can't throw a
SQLException here because we want
+ // to support jdbc tools such as Tableau.
+ @Override
+ public boolean isValid(int timeout) throws SQLException {
+ return true;
Review Comment:
should it check the `closed` flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
