Zakelly commented on code in PR #24878:
URL: https://github.com/apache/flink/pull/24878#discussion_r1626851630
##########
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##########
@@ -210,11 +209,11 @@ public class CheckpointingOptions {
* <p>Local recovery currently only covers keyed state backends.
Currently, MemoryStateBackend
* does not support local recovery and ignore this option.
*/
- @Documentation.Section(Documentation.Sections.COMMON_STATE_BACKENDS)
- public static final ConfigOption<String>
LOCAL_RECOVERY_TASK_MANAGER_STATE_ROOT_DIRS =
Review Comment:
Can we just rename variable name? I mean is there any a chance that a
developer use this?
##########
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##########
@@ -97,11 +97,11 @@ public class CheckpointingOptions {
* to {@link #CHECKPOINTS_DIRECTORY}, and the checkpoint meta data and
actual program state
* will both be persisted to the path.
*/
- @Documentation.Section(value =
Documentation.Sections.COMMON_STATE_BACKENDS, position = 2)
public static final ConfigOption<String> CHECKPOINT_STORAGE =
- ConfigOptions.key("state.checkpoint-storage")
Review Comment:
Some `state.checkpoint-storage` in documents should also be updated.
##########
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##########
@@ -97,11 +97,11 @@ public class CheckpointingOptions {
* to {@link #CHECKPOINTS_DIRECTORY}, and the checkpoint meta data and
actual program state
* will both be persisted to the path.
*/
- @Documentation.Section(value =
Documentation.Sections.COMMON_STATE_BACKENDS, position = 2)
Review Comment:
Do we need to remove the common state backends? Or we can rename it to
common_checkpointing or something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
