SinBex commented on code in PR #24887:
URL: https://github.com/apache/flink/pull/24887#discussion_r1627573467
##########
flink-tests/src/test/java/org/apache/flink/test/scheduling/SpeculativeExecutionITCase.java:
##########
@@ -524,30 +542,66 @@ public void open(GenericInputSplit split) throws
IOException {
}
private static class TestingNumberSequenceSource extends
NumberSequenceSource {
- private TestingNumberSequenceSource() {
+
+ private final boolean forceFailureFlag;
+
+ private TestingNumberSequenceSource(boolean forceFailureFlag) {
super(0, NUMBERS_TO_PRODUCE - 1);
+ this.forceFailureFlag = forceFailureFlag;
}
@Override
public SourceReader<Long, NumberSequenceSplit> createReader(
SourceReaderContext readerContext) {
- return new TestingIteratorSourceReader(readerContext);
+ return new TestingIteratorSourceReader(readerContext,
forceFailureFlag);
+ }
+
+ @Override
+ public SplitEnumerator<NumberSequenceSplit,
Collection<NumberSequenceSplit>>
+ createEnumerator(final
SplitEnumeratorContext<NumberSequenceSplit> enumContext) {
+
+ int splitSize = enumContext.currentParallelism();
+ if (forceFailureFlag) {
+ splitSize = 1;
Review Comment:
if 0 split, the source will not produce any data, leading to a mismatch in
unit test results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
