rkhachatryan commented on code in PR #24869:
URL: https://github.com/apache/flink/pull/24869#discussion_r1628468501
##########
flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java:
##########
@@ -1271,6 +1276,8 @@ public InlineElement getDescription() {
* @param classLoader a class loader to use when loading classes
*/
public void configure(ReadableConfig configuration, ClassLoader
classLoader) {
+ configuration.toMap().forEach(this.configuration::setString);
+
Review Comment:
This allows `ExecutionConfig` to pick up the unknown options without being
aware of them.
The downsides are:
- conversion to string (and from string when reading)
- picking up everything
However, I don't see any negative impact.
cc: @twalthr , @pnowojski, @StefanRRichter, @zentol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
