hackergin commented on code in PR #24888:
URL: https://github.com/apache/flink/pull/24888#discussion_r1628739971
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/workflow/scheduler/EmbeddedQuartzScheduler.java:
##########
@@ -271,11 +271,6 @@ public void deleteScheduleWorkflow(String workflowName,
String workflowGroup)
JobKey jobKey = JobKey.jobKey(workflowName, workflowGroup);
lock.writeLock().lock();
try {
- String errorMsg =
- String.format(
- "Failed to delete a non-existent quartz schedule
job: %s.", jobKey);
- checkJobExists(jobKey, errorMsg);
-
quartzScheduler.deleteJob(jobKey);
Review Comment:
Yes, In the testDropMaterializedTableWithDeletedRefreshWorkflowInFullMode
test, even if the workflow does not exist, `quartzScheduler.deleteJob(jobKey)`
will return normally without error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
