yuxiqian commented on code in PR #3364:
URL: https://github.com/apache/flink-cdc/pull/3364#discussion_r1629411656
##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistryRequestHandler.java:
##########
@@ -130,12 +130,13 @@ public CompletableFuture<CoordinationResponse>
handleSchemaChangeRequest(
LOG.info(
"Received schema change event request from table {}. Start
to buffer requests for others.",
request.getTableId().toString());
- if (request.getSchemaChangeEvent() instanceof CreateTableEvent
- && schemaManager.schemaExists(request.getTableId())) {
- return CompletableFuture.completedFuture(
- wrap(new
SchemaChangeResponse(Collections.emptyList())));
Review Comment:
I think this check is meant to avoid sending duplicate CreateTableEvent to
downstream after restored from checkpoints. Will this patch change that
behavior?
##########
flink-cdc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaManagerTest.java:
##########
Review Comment:
Could @hk-lrzy please add an integrated case to validate if route rule could
be correctly restored?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
