[
https://issues.apache.org/jira/browse/FLINK-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702206#comment-15702206
]
ASF GitHub Bot commented on FLINK-5179:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2886
[FLINK-5179] Correct TM MetricRegistry and TmMG lifecycle
This PR corrects the life-cycle of the MetricRegistry and
TaskManagerMetricGroup of the TaskManager.
The MetricRegistry is no longer shutdown when the TaskManager disassociates
from the JobManager; the registry, and by extension the reporters, will now
live and be active as long as the TaskManager is running.
The TaskManagerMetricGroup is now properly closed when disassociating from
the JobManager.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 5179_registry_lifecycle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2886.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2886
----
commit 32ee9b30f6cff3b17d30ad9b1920afb711c5263c
Author: zentol <ches...@apache.org>
Date: 2016-11-28T15:10:33Z
[FLINK-5179] Correct TM MetricRegistry and TmMG lifecycle
----
> MetricRegistry life-cycle issues with HA
> ----------------------------------------
>
> Key: FLINK-5179
> URL: https://issues.apache.org/jira/browse/FLINK-5179
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.1.3
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
> Fix For: 1.2.0, 1.1.4
>
>
> The TaskManager's MetricRegistry is started when the TaskManager is created,
> and shutdown in the TaskManager's postStop method.
> However, the registry is also shutdown within the TaskManager's
> disassociateFromJobManager method; however it is not restarted when the
> connection is re-established.
> Effectively this means that a TaskManager that ever reconnected to a
> JobManager will not report any metrics, since the reporters are shutdown as
> well. Metrics will neither be sent to the WebInterface anymore.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
