[ 
https://issues.apache.org/jira/browse/FLINK-4870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15702246#comment-15702246
 ] 

ASF GitHub Bot commented on FLINK-4870:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/2887

    [FLINK-4870] [FLINK-5162] Fix issues on windows related to Path/URI 
generation

    This PR fixes the FileSystemBlocStore and ContinuousFileMonitoringFunction 
on Windows.
    
    In both classes an URI is generated from a String and given to a Flink 
FileSystem instance. However, on Windows it is a hard requirement that all 
URI's that are generated first go through the Path class.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 5160_4870_test_uri_generation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2887.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2887
    
----
commit 2942b871ad1a0369e37aa72eae17ca6a126ee212
Author: zentol <[email protected]>
Date:   2016-11-25T12:23:56Z

    [FLINK-5162] Fix BlobRecoveryITCase#testBlobServerRecovery on Windows

commit 935943ad520e253d62da22f3320e15b619f11325
Author: zentol <[email protected]>
Date:   2016-11-25T12:27:43Z

    [FLINK-4870] Fix path handling in ContinuousFileMonitoringFunction

----


> ContinuousFileMonitoringFunction does not properly handle absolut Windows 
> paths
> -------------------------------------------------------------------------------
>
>                 Key: FLINK-4870
>                 URL: https://issues.apache.org/jira/browse/FLINK-4870
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 1.1.2
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Minor
>             Fix For: 1.2.0
>
>
> The ContinuousFileMonitoringFunction fails for absolute windows paths without 
>  a dedicated scheme (e.g "C:\\tmp\\test.csv"), since the String path is 
> directly fed into the URI constructor (which doesn't handle it properly) 
> instead of first creating a flink Path and converting that into an URI.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to