pnowojski commented on code in PR #24895:
URL: https://github.com/apache/flink/pull/24895#discussion_r1631413812
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamOperatorFactoryUtil.java:
##########
@@ -86,7 +86,11 @@ Tuple2<OP, Optional<ProcessingTimeService>> createOperator(
processingTimeService != null
? () -> processingTimeService
: processingTimeServiceFactory,
- operatorEventDispatcher));
+ operatorEventDispatcher,
+ mailboxExecutor));
+ if (op instanceof YieldingOperator) {
+ ((YieldingOperator<?>) op).setMailboxExecutor(mailboxExecutor);
+ }
Review Comment:
> I'd suggest we use the YeildingOperatorFactory to do so.
But then how would you pass mailbox from the factory to the operator? You
would still need to modify the operator one way or the other.
`AbstractStreamOperator` doesn't allow to do so. So either I would have to
still introduce `YieldingOperator` with this setter, or basically rewrite every
operator to use `AbstractStreamOperatorV2`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
