Zakelly commented on code in PR #24928:
URL: https://github.com/apache/flink/pull/24928#discussion_r1637493879
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/AcrossCheckpointFileMergingSnapshotManager.java:
##########
@@ -31,12 +33,13 @@ public class AcrossCheckpointFileMergingSnapshotManager
extends FileMergingSnaps
private final PhysicalFilePool filePool;
public AcrossCheckpointFileMergingSnapshotManager(
- String id,
+ JobID jobId,
+ ResourceID tmResourceId,
Review Comment:
I'd suggest a id string for `FileMergingManager`. It only need a unique id
without the knowledge of job or resource id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
