yuxiqian commented on code in PR #3398:
URL: https://github.com/apache/flink-cdc/pull/3398#discussion_r1639394005
##########
flink-cdc-dist/src/main/flink-cdc-bin/bin/flink-cdc.sh:
##########
@@ -70,4 +74,4 @@ LOG=$FLINK_CDC_LOG/flink-cdc-cli-$HOSTNAME.log
LOG_SETTINGS=(-Dlog.file="$LOG"
-Dlog4j.configuration=file:"$FLINK_CDC_CONF"/log4j-cli.properties
-Dlog4j.configurationFile=file:"$FLINK_CDC_CONF"/log4j-cli.properties)
# JAVA_RUN should have been setup in config.sh
-exec "$JAVA_RUN" -classpath "$CLASSPATH" "${LOG_SETTINGS[@]}"
org.apache.flink.cdc.cli.CliFrontend "$@"
+exec "$JAVA_RUN" -classpath "$CLASSPATH" "${LOG_SETTINGS[@]}"
org.apache.flink.cdc.cli.CliFrontend "$@"
Review Comment:
POSIX standard requires a newline at the EOF, so maybe we don't need to
change this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
