[ 
https://issues.apache.org/jira/browse/FLINK-5159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15703160#comment-15703160
 ] 

ASF GitHub Bot commented on FLINK-5159:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2811#discussion_r89811862
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/generated.scala
 ---
    @@ -41,3 +41,5 @@ object GeneratedExpression {
     }
     
     case class GeneratedFunction[T](name: String, returnType: 
TypeInformation[Any], code: String)
    +
    +case class GeneratedField(fieldName: String, fieldType: String)
    --- End diff --
    
    This is not used anymore, right?
    I think we should remove it.


> Improve perfomance of inner joins with a single row input
> ---------------------------------------------------------
>
>                 Key: FLINK-5159
>                 URL: https://issues.apache.org/jira/browse/FLINK-5159
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Alexander Shoshin
>            Assignee: Alexander Shoshin
>            Priority: Minor
>
> All inner joins (including a cross join) can be implemented as a 
> {{MapFunction}} if one of their inputs is a single row. This row can be 
> passed to a {{MapFunction}} as a {{BroadcastSet}}.
> This approach is going to be more lightweight than the other current 
> strategies.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to