Zakelly commented on code in PR #24933:
URL: https://github.com/apache/flink/pull/24933#discussion_r1641600159
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsMergingCheckpointStorageLocation.java:
##########
@@ -80,6 +80,9 @@ public FsMergingCheckpointStorageLocation(
reference,
fileStateSizeThreshold,
writeBufferSize);
+
+ // notify file merging snapshot manager when
FsMergingCheckpointStorageLocation create.
+ fileMergingSnapshotManager.notifyCheckpointStart(subtaskKey,
checkpointId);
Review Comment:
I'd suggest move this part to
`SubtaskCheckpointCoordinatorImpl#checkpointState` (before
`initInputsCheckpoint`, which may resolve the location), since the location
could be created twice for one checkpoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
