z3d1k commented on code in PR #143:
URL:
https://github.com/apache/flink-connector-aws/pull/143#discussion_r1642396219
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/util/TestUtil.java:
##########
@@ -36,6 +45,8 @@ public class TestUtil {
"arn:aws:kinesis:us-east-1:123456789012:stream/keenesesStream";
public static final String SHARD_ID = "shardId-000000000002";
public static final SimpleStringSchema STRING_SCHEMA = new
SimpleStringSchema();
+ public static final long MILLIS_BEHIND_LATEST_TEST_VALUE = 100L;
+ private static final Logger log = LoggerFactory.getLogger(TestUtil.class);
Review Comment:
Is this required? I don't see any usages of this field
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/metrics/KinesisSourceShardMetrics.java:
##########
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connector.kinesis.source.metrics;
+
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.connector.kinesis.source.split.KinesisShardSplit;
+import org.apache.flink.connector.kinesis.source.split.KinesisShardSplitState;
+import org.apache.flink.connector.kinesis.source.util.ArnUtil;
+import org.apache.flink.metrics.MetricGroup;
+import org.apache.flink.runtime.metrics.groups.AbstractMetricGroup;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import software.amazon.awssdk.arns.Arn;
+
+import java.util.HashMap;
+import java.util.Map;
+
+/**
+ * A collection class for handling metrics in {@link
org.apache.flink.connector.kinesis.source.reader.KinesisStreamsSourceReader}.
Review Comment:
nit: Util class instead of collection?
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/examples/SourceFromKinesis.java:
##########
@@ -34,7 +34,11 @@
public class SourceFromKinesis {
public static void main(String[] args) throws Exception {
- final StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
+ Configuration conf = new Configuration();
+// conf.setString("metrics.reporter.slf4j.factory.class",
"org.apache.flink.metrics.slf4j.Slf4jReporterFactory");
+// conf.setString("metrics.reporter.slf4j.interval", "15 SECONDS");
+
Review Comment:
Please remove commented out code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
