snuyanzin commented on code in PR #22775:
URL: https://github.com/apache/flink/pull/22775#discussion_r1642482796
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java:
##########
@@ -1038,9 +1112,9 @@ private static List<TestSetSpec> toStringCasts() {
DEFAULT_NEGATIVE_DOUBLE,
String.valueOf(DEFAULT_NEGATIVE_DOUBLE))
.fromCase(DATE(), DEFAULT_DATE, "2021-09-24")
- // https://issues.apache.org/jira/browse/FLINK-17224
Currently, fractional
- // seconds are lost
- .fromCase(TIME(5), DEFAULT_TIME, "12:34:56")
+ .fromCase(TIME(5), DEFAULT_TIME, "12:34:56.123")
Review Comment:
May be we still should put comment like micro and nano are not supported for
`TIME` yet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
