[
https://issues.apache.org/jira/browse/FLINK-4798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705143#comment-15705143
]
ASF GitHub Bot commented on FLINK-4798:
---------------------------------------
Github user BorisOsipov commented on a diff in the pull request:
https://github.com/apache/flink/pull/2843#discussion_r89996713
--- Diff:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java ---
@@ -361,17 +351,18 @@ public String select(Map<String, Event> pattern) {
}
);
- result.writeAsText(resultPath, FileSystem.WriteMode.OVERWRITE);
+ result.addSink(resultSink);
--- End diff --
I didn't find any of use`DataStreamUtils#collect()` in Flink tests.
`DataStreamUtils#collect()` places in
`<artifactId>flink-contrib</artifactId>` module. Are you sure that is a good
idea to depend on it?
I moved classes because I saw at least four implementations String\List
sinks for testing purpose. I guess it's a good idea to migrate to one of them
and get rid of usage temp files where possible.
What do you think? I'm newbie in a Flink and maybe wrong understand smth
> CEPITCase.testSimpleKeyedPatternCEP test failure
> ------------------------------------------------
>
> Key: FLINK-4798
> URL: https://issues.apache.org/jira/browse/FLINK-4798
> Project: Flink
> Issue Type: Bug
> Components: CEP
> Affects Versions: 1.2.0
> Reporter: Robert Metzger
> Assignee: Boris Osipov
> Labels: test-stability
>
> {code}
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Running org.apache.flink.cep.CEPITCase
> Tests run: 8, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 6.627 sec <<<
> FAILURE! - in org.apache.flink.cep.CEPITCase
> testSimpleKeyedPatternCEP(org.apache.flink.cep.CEPITCase) Time elapsed:
> 0.312 sec <<< FAILURE!
> java.lang.AssertionError: Different number of lines in expected and obtained
> result. expected:<3> but was:<1>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at
> org.apache.flink.test.util.TestBaseUtils.compareResultsByLinesInMemory(TestBaseUtils.java:316)
> at
> org.apache.flink.test.util.TestBaseUtils.compareResultsByLinesInMemory(TestBaseUtils.java:302)
> at org.apache.flink.cep.CEPITCase.after(CEPITCase.java:61)
> {code}
> in https://api.travis-ci.org/jobs/166676733/log.txt?deansi=true
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
