empathy87 opened a new pull request, #24979:
URL: https://github.com/apache/flink/pull/24979
## What is the purpose of the change
In `ParquetVectorizedInputFormat.java` the row group filter is set
```
FilterCompat.Filter filter = getFilter(hadoopConfig.conf());
ParquetReadOptions parquetReadOptions =
ParquetReadOptions.builder()
.withRange(splitOffset, splitOffset + splitLength)
.withRecordFilter(filter)
.build();
```
But the row groups are read incorrectly using `readNextRowGroup` instead of
`readNextFilteredRowGroup`. This affects the performance (filters are not
working because all row groups are read) and also could lead to incorrect
result because eventually returning here (totalRowCount are calculated with
filters applied):
```
if (rowsReturned >= totalRowCount) {
return false;
}
```
## Brief change log
- *Changed `readNextRowGroup` to `readNextFilteredRowGroup` in
`ParquetColumnarRowSplitReader::readNextRowGroup`*
- *Changed `readNextRowGroup` to `readNextFilteredRowGroup` in
`ParquetVectorizedInputFormat::readNextRowGroup`*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't
know)
- The S3 file system connector: (yes / no / **don't know**)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
