XComp commented on code in PR #24911:
URL: https://github.com/apache/flink/pull/24911#discussion_r1647485917
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionGraphHandler.java:
##########
@@ -81,23 +82,20 @@ public void reportCheckpointMetrics(
public void reportInitializationMetrics(
ExecutionAttemptID executionAttemptId,
SubTaskInitializationMetrics initializationMetrics) {
- if (executionGraph.getCheckpointStatsTracker() == null) {
+ final CheckpointCoordinatorConfiguration checkpointConfig =
+ executionGraph.getCheckpointCoordinatorConfiguration();
+ if (checkpointConfig == null ||
!checkpointConfig.isCheckpointingEnabled()) {
// TODO: Consider to support reporting initialization stats
without checkpointing
log.debug(
"Ignoring reportInitializationMetrics if checkpoint
coordinator is not present");
Review Comment:
Ok, the work I described in [my comment
above](https://github.com/apache/flink/pull/24911#discussion_r1647484212) makes
it necessary to verify the code. So, I might fix that along the way as well. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
