reswqa commented on code in PR #24999:
URL: https://github.com/apache/flink/pull/24999#discussion_r1665172689
##########
pom.xml:
##########
@@ -2383,6 +2383,9 @@ under the License.
<exclude>org.apache.flink.util.function.SerializableFunction</exclude>
<exclude>org.apache.flink.util.function.SupplierWithException</exclude>
<exclude>org.apache.flink.util.function.ThrowingConsumer</exclude>
+ <!-- Mark these
2 methods to @Internal. Tracked under FLINK-34130 -->
+
<exclude>org.apache.flink.configuration.Configuration#getBytes()</exclude>
Review Comment:
I guess we shouldn't ignore the param's type here, otherwise how this plugin
identify overload methods?
##########
pom.xml:
##########
@@ -2383,6 +2383,9 @@ under the License.
<exclude>org.apache.flink.util.function.SerializableFunction</exclude>
<exclude>org.apache.flink.util.function.SupplierWithException</exclude>
<exclude>org.apache.flink.util.function.ThrowingConsumer</exclude>
+ <!-- Mark these
2 methods to @Internal. Tracked under FLINK-34130 -->
+
<exclude>org.apache.flink.configuration.Configuration#getBytes()</exclude>
Review Comment:
I guess we shouldn't ignore params type here, otherwise how this plugin
identify overload methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
